Adding step to upload valgrind report in integration tests#57
Merged
sumit-sen-dc merged 2 commits intomainfrom Mar 31, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds artifact upload steps to persist Valgrind reports produced during integration test workflows, improving post-run diagnostics.
Changes:
- Upload Valgrind report zip artifacts (with 5-day retention) in NanoSSL, NanoSSH, NanoCert SCEP, and NanoCert EST integration workflows.
- Update NanoSSL workflow to
cdinto the clonedmocn-qa-m-productsrepo and checkout a specific ref. - Remove an extraneous line under the NanoCert SCEP workflow name header.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| .github/workflows/nanossl_integration_test.yml | Adds Valgrind artifact upload; also checks out a specific ref in the external QA repo. |
| .github/workflows/nanossh_integration_test.yml | Adds Valgrind artifact upload after SSH integration tests. |
| .github/workflows/nanocert_scep_integration_test.yml | Cleans up header formatting and adds Valgrind client artifact upload. |
| .github/workflows/nanocert_est_integration_test.yml | Adds Valgrind client artifact upload. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sumit-sen-dc
approved these changes
Mar 31, 2026
sumit-sen-dc
deleted the
DTM-7857-add-upload-valrgind-report-step-for-all-the-integration-test-workflow-files-in-trustcore
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.